Re: [ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 08:20:28AM -0700, Gurucharan Shetty wrote: > On Sat, Jul 11, 2015 at 9:56 AM, Ben Pfaff wrote: > > On Fri, Jul 10, 2015 at 09:26:07PM -0700, Gurucharan Shetty wrote: > >> MSVC 2013 does not like designated initializers when > >> structs are initialized inside structs. > >>

Re: [ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-14 Thread Gurucharan Shetty
On Sat, Jul 11, 2015 at 9:56 AM, Ben Pfaff wrote: > On Fri, Jul 10, 2015 at 09:26:07PM -0700, Gurucharan Shetty wrote: >> MSVC 2013 does not like designated initializers when >> structs are initialized inside structs. >> >> Signed-off-by: Gurucharan Shetty > > Ugh. > > Acked-by: Ben Pfaff > > (P

Re: [ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-11 Thread Ben Pfaff
On Fri, Jul 10, 2015 at 09:26:07PM -0700, Gurucharan Shetty wrote: > MSVC 2013 does not like designated initializers when > structs are initialized inside structs. > > Signed-off-by: Gurucharan Shetty Ugh. Acked-by: Ben Pfaff (Patch 1 looked OK too but I'm not really an expert on that code an

[ovs-dev] [PATCH 2/2] CodingStyle: Remove designated initialzers as acceptable.

2015-07-10 Thread Gurucharan Shetty
MSVC 2013 does not like designated initializers when structs are initialized inside structs. Signed-off-by: Gurucharan Shetty --- CodingStyle.md |4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/CodingStyle.md b/CodingStyle.md index 0a441e0..54dadf1 100644 --- a/CodingSt