hi,
thanks for reviewing.
> Yamamoto-san,
>
> Thanks for this work. I'm happy that it will result in BSD systems as
> a group getting more OVS test coverage.
>
> The patch set builds and passes unit tests for me on FreeBSD, with the
> exception of the missing #if defined() guard described in a
On Wed, Apr 24, 2013 at 10:39:23AM -0400, Ed Maste wrote:
> I have only one overall comment: I personally don't like the style of
> platform-specific #if #elif cases within the function definition,
> where none of the body is common to the implementations. I'll comment
> on the two cases (netdev_b
Yamamoto-san,
Thanks for this work. I'm happy that it will result in BSD systems as
a group getting more OVS test coverage.
The patch set builds and passes unit tests for me on FreeBSD, with the
exception of the missing #if defined() guard described in a previous
email.
I have only one overall
On Tue, Apr 23, 2013 at 08:57:28AM -0400, Ed Maste wrote:
> > Ed, do you want to look over any of these changes? They affect code
> > for which you are a primary author, so if you would prefer to see
> > anything done a different way, etc., for maintainability purposes then
> > it would be valuabl
> Ed, do you want to look over any of these changes? They affect code
> for which you are a primary author, so if you would prefer to see
> anything done a different way, etc., for maintainability purposes then
> it would be valuable to get that in review.
Yep - I'm looking at them now. I've rev
On Mon, Apr 22, 2013 at 10:20:13PM +0900, YAMAMOTO Takashi wrote:
> mostly ride on the existing FreeBSD support.
>
> Signed-off-by: YAMAMOTO Takashi
Ed, do you want to look over any of these changes? They affect code
for which you are a primary author, so if you would prefer to see
anything don
mostly ride on the existing FreeBSD support.
Signed-off-by: YAMAMOTO Takashi
---
lib/command-line.c| 4 ++--
lib/command-line.h| 2 +-
lib/netdev-bsd.c | 37 -
lib/netdev-dummy.c| 8
lib/netdev-provider.h | 2 +-
lib/netdev.c
