Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-19 Thread Jarno Rajahalme
On Nov 19, 2014, at 12:21 PM, Daniele Venturino wrote: > Thanks! > > On patch 14/17 there’s a little change to add, which I anticipated in my > previous mail. > bundle_move() expects two “struct ofbundle” as arguments. With the current > patch the two tests pertaining the MAC learning shifti

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-19 Thread Daniele Venturino
Thanks! On patch 14/17 there’s a little change to add, which I anticipated in my previous mail. bundle_move() expects two “struct ofbundle” as arguments. With the current patch the two tests pertaining the MAC learning shifting fail. I just tested the merged version and this seems to be a good s

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-19 Thread Jarno Rajahalme
Daniele, Thanks for testing, pushed to master. Jarno On Nov 17, 2014, at 9:13 AM, Daniele Venturino wrote: >> The problem must be that the port number and the hash value get out of sync, >> i.e., when the port number is changed. Please try the patch below on top of >> your patch and check

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-19 Thread Jarno Rajahalme
Daniele, Thanks for testing, pushed to master. Jarno On Nov 17, 2014, at 9:13 AM, Daniele Venturino wrote: >> The problem must be that the port number and the hash value get out of sync, >> i.e., when the port number is changed. Please try the patch below on top of >> your patch and check

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-17 Thread Daniele Venturino
> The problem must be that the port number and the hash value get out of sync, > i.e., when the port number is changed. Please try the patch below on top of > your patch and check if you still have the same problem. With your modifications pertaining the hashmap those tests passed. I had to reve

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-14 Thread Jarno Rajahalme
On Nov 14, 2014, at 9:19 AM, Daniele Venturino wrote: > Why lose the ‘_WITH_HASH’? It seems pointless to iterate over all the ports, > when we just care of the port with the ‘port_number’? > > With the _WITH_HASH a test on learned addresses shifting fails. It seems like > it doesn't even ente

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-14 Thread Daniele Venturino
> > Why lose the ‘_WITH_HASH’? It seems pointless to iterate over all the > ports, when we just care of the port with the ‘port_number’? With the _WITH_HASH a test on learned addresses shifting fails. It seems like it doesn't even enter the FOR_EACH cycle when the port_number is not 1, maybe ther

Re: [ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-13 Thread Jarno Rajahalme
Daniele, See comments inline. Thanks! Jarno On Nov 6, 2014, at 7:31 AM, Daniele Venturino wrote: > All MAC addresses previously learned on a Root Port can be moved to an > Alternate Port that becomes the new Root Port; i.e., Dynamic Filtering > Entries for those addresses may

[ovs-dev] [PATCH 14/17] rstp: shift learned MAC addresses to new Root port.

2014-11-06 Thread Daniele Venturino
All MAC addresses previously learned on a Root Port can be moved to an Alternate Port that becomes the new Root Port; i.e., Dynamic Filtering Entries for those addresses may be modified to show the new Root Port as their source, reducing the need to flood frames when recover