Re: [ovs-dev] [PATCH 13/23] ovn: Implement logical patch ports.

2015-10-16 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 05:48:30PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > > > diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c > > index 90c72ff..f25709c 100644 > > --- a/ovn/controller/patch.c > > +++ b/ovn/controller/patch.c > > @@ -50,7

Re: [ovs-dev] [PATCH 13/23] ovn: Implement logical patch ports.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:20 PM, Ben Pfaff wrote: > > diff --git a/ovn/controller/patch.c b/ovn/controller/patch.c > index 90c72ff..f25709c 100644 > --- a/ovn/controller/patch.c > +++ b/ovn/controller/patch.c > @@ -50,7 +50,7 @@ match_patch_port(const struct ovsrec_port *port, const char > *peer)

[ovs-dev] [PATCH 13/23] ovn: Implement logical patch ports.

2015-10-09 Thread Ben Pfaff
This implementation is suboptimal for several reasons. First, it creates an OVS port for every OVN logical patch port, not just for the ones that are actually useful on this hypervisor. Second, it's wasteful to create an OVS patch port per OVN logical patch port, when really there's no benefit to