Re: [ovs-dev] [PATCH 10/23] patch: Refactor to better support new kinds of patches.

2015-10-16 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 04:38:57PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > +/* Add any patch ports that should exist but don't. */ > > +parse_bridge_mappings(ctx, br_int, &existing_ports); > > This comment could probably use a bit more info

Re: [ovs-dev] [PATCH 10/23] patch: Refactor to better support new kinds of patches.

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > +/* Add any patch ports that should exist but don't. */ > +parse_bridge_mappings(ctx, br_int, &existing_ports); This comment could probably use a bit more information. > +/* Delete any patch ports that do exist but shouldn't. (Any

[ovs-dev] [PATCH 10/23] patch: Refactor to better support new kinds of patches.

2015-10-09 Thread Ben Pfaff
Until now, the code here lumped together what was necessary to create and destroy patch ports, with what was necessary to identify the patch ports that were needed. An upcoming patch will add new reasons to create patch ports, so this commit more cleanly separates those two functions. Signed-off-