Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 09:24:20AM -0700, Jesse Gross wrote: > On Wed, Jun 24, 2015 at 7:09 PM, Ben Pfaff wrote: > > On Wed, Jun 24, 2015 at 06:34:05PM -0700, Jesse Gross wrote: > >> On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff wrote: > >> > On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wro

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-25 Thread Jesse Gross
On Wed, Jun 24, 2015 at 7:09 PM, Ben Pfaff wrote: > On Wed, Jun 24, 2015 at 06:34:05PM -0700, Jesse Gross wrote: >> On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff wrote: >> > On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: >> > I like the implementation approach used in ULONG_FOR_EACH_1

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 06:34:05PM -0700, Jesse Gross wrote: > On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff wrote: > > On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: > > I like the implementation approach used in ULONG_FOR_EACH_1 better than > > the one in PRESENT_OPT_FOR_EACH, since t

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-24 Thread Jesse Gross
On Wed, Jun 24, 2015 at 3:57 PM, Ben Pfaff wrote: > On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: >> The current support for Geneve in OVS is exactly equivalent to VXLAN: >> it is possible to set and match on the VNI but not on any options >> contained in the header. This patch enab

Re: [ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-24 Thread Ben Pfaff
On Fri, Jun 19, 2015 at 04:13:24PM -0700, Jesse Gross wrote: > The current support for Geneve in OVS is exactly equivalent to VXLAN: > it is possible to set and match on the VNI but not on any options > contained in the header. This patch enables the use of options. > > The goal for Geneve support

[ovs-dev] [PATCH 10/11] tunnel: Geneve TLV handling support for OpenFlow.

2015-06-19 Thread Jesse Gross
The current support for Geneve in OVS is exactly equivalent to VXLAN: it is possible to set and match on the VNI but not on any options contained in the header. This patch enables the use of options. The goal for Geneve support is not to add support for any particular option but to allow end users