Re: [ovs-dev] [PATCH 1/6] ovs-xapi-sync: Remove useless root_prefix global.

2012-03-08 Thread Ethan Jackson
> The stuff that this series modifies has had some churn lately and so > it doesn't apply cleanly against current master.  What commit is it > based on? Currently I have it on top of c9a2d670ebf21d28940ecb1f56b8afde665b4495 "python: Make build number format consistent with C." in my tree, but I do

Re: [ovs-dev] [PATCH 1/6] ovs-xapi-sync: Remove useless root_prefix global.

2012-03-08 Thread Ben Pfaff
The stuff that this series modifies has had some churn lately and so it doesn't apply cleanly against current master. What commit is it based on? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

Re: [ovs-dev] [PATCH 1/6] ovs-xapi-sync: Remove useless root_prefix global.

2012-03-07 Thread Ethan Jackson
> (It was global because I copied its usage from interface-reconfigure, > where it is used much more extensively.) This code has changed quite a bit too. I had assumed that a global was once necessary and no longer is. Ethan ___ dev mailing list dev@op

Re: [ovs-dev] [PATCH 1/6] ovs-xapi-sync: Remove useless root_prefix global.

2012-03-07 Thread Ben Pfaff
On Wed, Mar 07, 2012 at 05:09:22PM -0800, Ethan Jackson wrote: > There's no reason for this variable to be global, or to exist at > all for that matter. > > Signed-off-by: Ethan Jackson Looks good, thanks. (It was global because I copied its usage from interface-reconfigure, where it is used mu

[ovs-dev] [PATCH 1/6] ovs-xapi-sync: Remove useless root_prefix global.

2012-03-07 Thread Ethan Jackson
There's no reason for this variable to be global, or to exist at all for that matter. Signed-off-by: Ethan Jackson --- .../usr_share_openvswitch_scripts_ovs-xapi-sync|9 ++--- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/xenserver/usr_share_openvswitch_scripts_ovs-xa