Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: Test flow stats reporting.

2014-02-25 Thread Ben Pfaff
Yes, I was really satisfied to see that, because I'd spent some time trying to debug that problem myself. The issue is pretty subtle. On Tue, Feb 25, 2014 at 4:04 PM, Joe Stringer wrote: > Thanks! Glad to hear that it fixes the intermittent failures. > > > On 25 February 2014 14:58, Ben Pfaff w

Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: Test flow stats reporting.

2014-02-25 Thread Joe Stringer
Thanks! Glad to hear that it fixes the intermittent failures. On 25 February 2014 14:58, Ben Pfaff wrote: > On Tue, Feb 11, 2014 at 01:55:32PM -0800, Joe Stringer wrote: > > Basic test to check that the datapath reports the correct number of > > packets seen, after a delay of 1 second. > > > >

Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: Test flow stats reporting.

2014-02-25 Thread Ben Pfaff
On Tue, Feb 11, 2014 at 01:55:32PM -0800, Joe Stringer wrote: > Basic test to check that the datapath reports the correct number of > packets seen, after a delay of 1 second. > > Signed-off-by: Joe Stringer This series appear to fix the intermittent failure of test 683 "ofproto-dpif - controller

Re: [ovs-dev] [PATCH 1/5] ofproto-dpif: Test flow stats reporting.

2014-02-24 Thread Joe Stringer
Ping, the series beginning here fixes various stats duplication bugs introduced with the revalidation threading patches: * Flows missed during a datapath dump will have their stats duplicated (Caused by flow deletions while dumping) * Flows that are dumped twice may have their stats duplicated (Ca

[ovs-dev] [PATCH 1/5] ofproto-dpif: Test flow stats reporting.

2014-02-11 Thread Joe Stringer
Basic test to check that the datapath reports the correct number of packets seen, after a delay of 1 second. Signed-off-by: Joe Stringer --- tests/ofproto-dpif.at | 21 + 1 file changed, 21 insertions(+) diff --git a/tests/ofproto-dpif.at b/tests/ofproto-dpif.at index 8dcd