Re: [ovs-dev] [PATCH 1/5] lib/ofp: Consolidate some struct field orders

2013-12-13 Thread Helmut Schaa
On Fri, Dec 13, 2013 at 5:35 PM, Ben Pfaff wrote: > On Fri, Dec 13, 2013 at 02:17:13PM +0100, Helmut Schaa wrote: >> Avoid "holes" in structs by moving "small" members together. >> >> Signed-off-by: Helmut Schaa > > I don't think any of these is particularly useful. Most notably, the > two "ofpu

Re: [ovs-dev] [PATCH 1/5] lib/ofp: Consolidate some struct field orders

2013-12-13 Thread Ben Pfaff
On Fri, Dec 13, 2013 at 02:17:13PM +0100, Helmut Schaa wrote: > Avoid "holes" in structs by moving "small" members together. > > Signed-off-by: Helmut Schaa I don't think any of these is particularly useful. Most notably, the two "ofputil_*" structures are only ever allocated one at a time, on

[ovs-dev] [PATCH 1/5] lib/ofp: Consolidate some struct field orders

2013-12-13 Thread Helmut Schaa
Avoid "holes" in structs by moving "small" members together. Signed-off-by: Helmut Schaa --- lib/ofp-actions.h | 2 +- lib/ofp-util.h| 8 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lib/ofp-actions.h b/lib/ofp-actions.h index 470a371..00cba6a 100644 --- a/lib/ofp-