Re: [ovs-dev] [PATCH 1/5] lib/flow: Introduce miniflow_extract().

2014-05-07 Thread Jarno Rajahalme
>> >> >> +/* Metadata. */ >> if (md) { >> -flow->tunnel = md->tunnel; >> -flow->in_port = md->in_port; >> -flow->skb_priority = md->skb_priority; >> -flow->pkt_mark = md->pkt_mark; >> -flow->recirc_id = md->recirc_id; >> -flow->dp_hash = md

Re: [ovs-dev] [PATCH 1/5] lib/flow: Introduce miniflow_extract().

2014-05-06 Thread Joe Stringer
Hi Jarno, Quick question.. On 18 April 2014 13:36, Jarno Rajahalme wrote: > miniflow_extract() extracts packet headers directly to a miniflow, > which is a compressed form of the struct flow. This does not require > a large struct to be cleared to begin with, and accesses less memory. > These

Re: [ovs-dev] [PATCH 1/5] lib/flow: Introduce miniflow_extract().

2014-04-18 Thread Jarno Rajahalme
Pushed, thanks for the prompt review! Jarno On Apr 18, 2014, at 2:32 AM, YAMAMOTO Takashi wrote: >> miniflow_extract() extracts packet headers directly to a miniflow, >> which is a compressed form of the struct flow. This does not require >> a large struct to be cleared to begin with, and ac

Re: [ovs-dev] [PATCH 1/5] lib/flow: Introduce miniflow_extract().

2014-04-18 Thread YAMAMOTO Takashi
> miniflow_extract() extracts packet headers directly to a miniflow, > which is a compressed form of the struct flow. This does not require > a large struct to be cleared to begin with, and accesses less memory. > These performance benefits should allow this to be used in the DPDK > datapath. > >

[ovs-dev] [PATCH 1/5] lib/flow: Introduce miniflow_extract().

2014-04-17 Thread Jarno Rajahalme
miniflow_extract() extracts packet headers directly to a miniflow, which is a compressed form of the struct flow. This does not require a large struct to be cleared to begin with, and accesses less memory. These performance benefits should allow this to be used in the DPDK datapath. miniflow_extr