Re: [ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-04-07 Thread Ben Pfaff
On Thu, Apr 03, 2014 at 05:47:04PM -0700, Pravin Shelar wrote: > On Thu, Apr 3, 2014 at 2:41 PM, Ben Pfaff wrote: > > I don't like seeing this as a global variable. Can it be per-datapath > > (probably set using a new provider callback function)? > > > There can be only one definition of this cal

Re: [ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-04-03 Thread Pravin Shelar
On Thu, Apr 3, 2014 at 3:09 PM, Ben Pfaff wrote: > An additional comment on the whole series: I think that it is broken > up into too many patches, because I found it hard to piece together > the overall effect. Please consider whether some patches make sense > squashed together. ok, I will to i

Re: [ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-04-03 Thread Pravin Shelar
On Thu, Apr 3, 2014 at 2:41 PM, Ben Pfaff wrote: > On Thu, Mar 27, 2014 at 09:44:18AM -0700, Pravin wrote: >> This patch does not change any functionality. >> >> Signed-off-by: Pravin B Shelar > > I don't like seeing this as a global variable. Can it be per-datapath > (probably set using a new p

Re: [ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-04-03 Thread Ben Pfaff
An additional comment on the whole series: I think that it is broken up into too many patches, because I found it hard to piece together the overall effect. Please consider whether some patches make sense squashed together. ___ dev mailing list dev@openv

Re: [ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-04-03 Thread Ben Pfaff
On Thu, Mar 27, 2014 at 09:44:18AM -0700, Pravin wrote: > This patch does not change any functionality. > > Signed-off-by: Pravin B Shelar I don't like seeing this as a global variable. Can it be per-datapath (probably set using a new provider callback function)? Did you look for races as ofpr

[ovs-dev] [PATCH 1/5] dpif: Introduce ofproto flow lookup function.

2014-03-27 Thread Pravin
This patch does not change any functionality. Signed-off-by: Pravin B Shelar --- lib/dpif.c |5 + lib/dpif.h | 23 +++ 2 files changed, 28 insertions(+) diff --git a/lib/dpif.c b/lib/dpif.c index 6649176..dc1e8c0 100644 --- a/lib/dpif.c +++ b/lib/dpif.c @@ -56,6 +5