Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Jarno Rajahalme
Thanks guys, series pushed to master, Jarno On May 28, 2014, at 4:55 PM, Ben Pfaff wrote: > On Wed, May 28, 2014 at 04:52:59PM -0700, Jarno Rajahalme wrote: >> >> On May 28, 2014, at 4:00 PM, Ethan Jackson wrote: >> >>> FWIW I'd prefer we don't mix declarations and code unless there's a >>

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Ben Pfaff
On Wed, May 28, 2014 at 04:52:59PM -0700, Jarno Rajahalme wrote: > > On May 28, 2014, at 4:00 PM, Ethan Jackson wrote: > > > FWIW I'd prefer we don't mix declarations and code unless there's a > > clear reason to do it from a simplicity perspective. I.E. I think we > > should go from mandating

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Jarno Rajahalme
On May 28, 2014, at 4:00 PM, Ethan Jackson wrote: > FWIW I'd prefer we don't mix declarations and code unless there's a > clear reason to do it from a simplicity perspective. I.E. I think we > should go from mandating that it's never allowed, to suggesting that > it's discouraged. The reason i

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Ben Pfaff
On Wed, May 28, 2014 at 04:00:03PM -0700, Ethan Jackson wrote: > FWIW I'd prefer we don't mix declarations and code unless there's a > clear reason to do it from a simplicity perspective. I.E. I think we > should go from mandating that it's never allowed, to suggesting that > it's discouraged. Th

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Ethan Jackson
FWIW I'd prefer we don't mix declarations and code unless there's a clear reason to do it from a simplicity perspective. I.E. I think we should go from mandating that it's never allowed, to suggesting that it's discouraged. The reason is that most of the code doesn't do these things, and there's

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Ben Pfaff
On Wed, May 28, 2014 at 03:31:03PM -0700, Jarno Rajahalme wrote: > > On May 23, 2014, at 10:04 AM, Ben Pfaff wrote: > > > On Thu, May 22, 2014 at 05:37:38PM -0700, Jarno Rajahalme wrote: > >> As even the MSVC 2013 now supports the C99 mixing of declarations and > >> code, we can now allow them i

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-28 Thread Jarno Rajahalme
On May 23, 2014, at 10:04 AM, Ben Pfaff wrote: > On Thu, May 22, 2014 at 05:37:38PM -0700, Jarno Rajahalme wrote: >> As even the MSVC 2013 now supports the C99 mixing of declarations and >> code, we can now allow them in OVS code. >> >> GCC (at least some versions of it) require the -std=c99 op

Re: [ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-23 Thread Ben Pfaff
On Thu, May 22, 2014 at 05:37:38PM -0700, Jarno Rajahalme wrote: > As even the MSVC 2013 now supports the C99 mixing of declarations and > code, we can now allow them in OVS code. > > GCC (at least some versions of it) require the -std=c99 option to not > issue warnings, and since we rely in GCC e

[ovs-dev] [PATCH 1/5] CodingStyle: Allow C99 mixing of declarations and code.

2014-05-22 Thread Jarno Rajahalme
As even the MSVC 2013 now supports the C99 mixing of declarations and code, we can now allow them in OVS code. GCC (at least some versions of it) require the -std=c99 option to not issue warnings, and since we rely in GCC extensions when compiling with GCC, the option -std=gnu99 is now added to th