Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-19 Thread Saurabh Shah
>On Tue, Aug 19, 2014 at 02:10:50AM +, Saurabh Shah wrote: >> Hi Ben, >> >> >On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote: >> >> The datapath interface defined in odp-netlink.h needs some extensions >> >> that are platform dependent. Some examples are the name of the >> >>commu

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-19 Thread Ben Pfaff
On Tue, Aug 19, 2014 at 02:10:50AM +, Saurabh Shah wrote: > Hi Ben, > > >On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote: > >> The datapath interface defined in odp-netlink.h needs some extensions > >> that are platform dependent. Some examples are the name of the > >>communication

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-19 Thread Nithin Raju
> Is there any objection if we directly include OvsDpInterfaceExt.h in > userspace (with the right #ifdefs, of course)? I don't understand why we > would want to auto-generate a file just to include the kernel header file. > This is what the auto-generated file is supposed to look like - > > /* >

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-18 Thread Saurabh Shah
Hi Ben, >On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote: >> The datapath interface defined in odp-netlink.h needs some extensions >> that are platform dependent. Some examples are the name of the >>communication >> device on Windows and a set of commands that are specific to Windows.

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-18 Thread Nithin Raju
On Aug 18, 2014, at 5:14 PM, Alin Serdean wrote: > I'm fine with this patch with the idea in mind that OvsDpInterfaceExt.h can > be added to odp-netlink.h. Not sure about the name though :). Alin, As the name indicates, the idea is to add "extensions" to the DP interface. We could add the co

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-18 Thread Alin Serdean
ithin Raju Trimis: Friday, August 15, 2014 6:36 AM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface The datapath interface defined in odp-netlink.h needs some extensions that are platform dependent. Some examples are the name o

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-15 Thread Nithin Raju
On Aug 15, 2014, at 1:24 PM, Ben Pfaff wrote: > I'm fine with this. I'd like someone else to review the actual > Windows-specific bits. Thanks Ben. Ankur and Saurabh have reviewed the Windows bits and are fine with it. I am waiting for Alin and Samuel's review. thanks, Nithin ___

Re: [ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-15 Thread Ben Pfaff
On Thu, Aug 14, 2014 at 08:35:36PM -0700, Nithin Raju wrote: > The datapath interface defined in odp-netlink.h needs some extensions > that are platform dependent. Some examples are the name of the communication > device on Windows and a set of commands that are specific to Windows. > > In this ch

[ovs-dev] [PATCH 1/4 v2] Add extentions to the standard datapath interface

2014-08-14 Thread Nithin Raju
The datapath interface defined in odp-netlink.h needs some extensions that are platform dependent. Some examples are the name of the communication device on Windows and a set of commands that are specific to Windows. In this change we define a include/odp-netlink-ext.h to in turn include any platf