Re: [ovs-dev] [PATCH 1/4] expr: Simplify "x == 0/0" into 1.

2016-10-10 Thread Andy Zhou
On Thu, Oct 6, 2016 at 8:30 PM, Ben Pfaff wrote: > An expression like "x == 0/0" does not test any actual bits in field x, > so it resolves to true, but expr_simplify() was not smart enough to see > this. > > This goes beyond an optimization, to become a bug fix, because > expr_normalize() will a

[ovs-dev] [PATCH 1/4] expr: Simplify "x == 0/0" into 1.

2016-10-06 Thread Ben Pfaff
An expression like "x == 0/0" does not test any actual bits in field x, so it resolves to true, but expr_simplify() was not smart enough to see this. This goes beyond an optimization, to become a bug fix, because expr_normalize() will assert-fail for expressions that become trivial when this simpl