Re: [ovs-dev] [PATCH 1/4] dpif-linux: Avoid null dereference if all ports disappear.

2014-07-15 Thread Ben Pfaff
On Tue, Jul 15, 2014 at 04:13:05PM +1200, Joe Stringer wrote: > On 15 July 2014 09:10, Ben Pfaff wrote: > > > When dpif_linux_refresh_channels() refreshes the set of channels when > > the number of handlers changes, it destroys all the dpif's channels and > > sets dpif->uc_array_size to 0. If th

Re: [ovs-dev] [PATCH 1/4] dpif-linux: Avoid null dereference if all ports disappear.

2014-07-14 Thread Joe Stringer
On 15 July 2014 09:10, Ben Pfaff wrote: > When dpif_linux_refresh_channels() refreshes the set of channels when > the number of handlers changes, it destroys all the dpif's channels and > sets dpif->uc_array_size to 0. If the port dump later in the function > turns up no ports (which generally i

[ovs-dev] [PATCH 1/4] dpif-linux: Avoid null dereference if all ports disappear.

2014-07-14 Thread Ben Pfaff
When dpif_linux_refresh_channels() refreshes the set of channels when the number of handlers changes, it destroys all the dpif's channels and sets dpif->uc_array_size to 0. If the port dump later in the function turns up no ports (which generally indicates a bug), then no channels will be allocate