Re: [ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Simon Horman
On Wed, Jul 04, 2012 at 05:49:30PM -0700, Ben Pfaff wrote: > On Thu, Jul 05, 2012 at 09:47:29AM +0900, Simon Horman wrote: > > On Wed, Jul 04, 2012 at 05:34:43PM -0700, Ben Pfaff wrote: > > > On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote: > > > > On Wed, Jul 04, 2012 at 02:55:52PM -0

Re: [ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Ben Pfaff
On Thu, Jul 05, 2012 at 09:47:29AM +0900, Simon Horman wrote: > On Wed, Jul 04, 2012 at 05:34:43PM -0700, Ben Pfaff wrote: > > On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote: > > > On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote: > > > > On Wed, Jul 04, 2012 at 05:50:41PM +0

Re: [ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Simon Horman
On Wed, Jul 04, 2012 at 05:34:43PM -0700, Ben Pfaff wrote: > On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote: > > On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote: > > > On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote: > > > > PCP depends on the presence of VID so

Re: [ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Ben Pfaff
On Thu, Jul 05, 2012 at 09:27:05AM +0900, Simon Horman wrote: > On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote: > > On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote: > > > PCP depends on the presence of VID so it seems to make sense > > > to set the CFI bit as part of setting

Re: [ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Simon Horman
On Wed, Jul 04, 2012 at 02:55:52PM -0700, Ben Pfaff wrote: > On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote: > > PCP depends on the presence of VID so it seems to make sense > > to set the CFI bit as part of setting the VID rather than the PCP. > > > > Signed-off-by: Simon Horman >

Re: [ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Ben Pfaff
On Wed, Jul 04, 2012 at 05:50:41PM +0900, Simon Horman wrote: > PCP depends on the presence of VID so it seems to make sense > to set the CFI bit as part of setting the VID rather than the PCP. > > Signed-off-by: Simon Horman The following change definitely can't be correct because OFP_VLAN_NONE

[ovs-dev] [PATCH 1/4] classifier, flow : Set CFI as part of VID

2012-07-04 Thread Simon Horman
PCP depends on the presence of VID so it seems to make sense to set the CFI bit as part of setting the VID rather than the PCP. Signed-off-by: Simon Horman --- lib/classifier.c | 2 +- lib/flow.c | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/classifier.c b/li