Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Joe Stringer
On 23 September 2016 at 12:13, Justin Pettit wrote: > >> On Sep 23, 2016, at 10:10 AM, Joe Stringer wrote: >> >> On 23 September 2016 at 01:53, Justin Pettit wrote: >>> >>> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h >>> index 5ab026c..9d53623 100644 >>> --- a/incl

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 10:10 AM, Joe Stringer wrote: > > On 23 September 2016 at 01:53, Justin Pettit wrote: >> >> diff --git a/include/openflow/nicira-ext.h b/include/openflow/nicira-ext.h >> index 5ab026c..9d53623 100644 >> --- a/include/openflow/nicira-ext.h >> +++ b/include/openflow/nicira-

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Joe Stringer
On 23 September 2016 at 01:53, Justin Pettit wrote: > Signed-off-by: Justin Pettit > --- > NEWS | 1 + > debian/changelog | 10 ++ > include/openflow/nicira-ext.h | 9 + > include/openvswitch/ofp-msgs.h | 4 > lib/dpif.c

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Justin Pettit
> On Sep 23, 2016, at 8:42 AM, Ben Pfaff wrote: > > On Fri, Sep 23, 2016 at 01:53:00AM -0700, Justin Pettit wrote: >> Signed-off-by: Justin Pettit > > ct_dpif_flush() and dpif_ct_flush() are almost identical. Why do we > need both? > > Acked-by: Ben Pfaff Just an oversight. I'll add my lo

Re: [ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Ben Pfaff
On Fri, Sep 23, 2016 at 01:53:00AM -0700, Justin Pettit wrote: > Signed-off-by: Justin Pettit ct_dpif_flush() and dpif_ct_flush() are almost identical. Why do we need both? Acked-by: Ben Pfaff ___ dev mailing list dev@openvswitch.org http://openvswit

[ovs-dev] [PATCH 1/4] Add OpenFlow command to flush conntrack table entries.

2016-09-23 Thread Justin Pettit
Signed-off-by: Justin Pettit --- NEWS | 1 + debian/changelog | 10 ++ include/openflow/nicira-ext.h | 9 + include/openvswitch/ofp-msgs.h | 4 lib/dpif.c | 14 ++ lib/dpif.h | 1