Re: [ovs-dev] [PATCH 1/3 v2] datapath-windows: add netlink message parsing APIs

2014-08-22 Thread Ankur Sharma
Hi Saurabh, I took i am fine with the change as an ack. I'll wait for explicit ack next time. Regads, Ankur From: Saurabh Shah Sent: Friday, August 22, 2014 1:35 PM To: Ankur Sharma; dev@openvswitch.org Subject: Re: [ovs-dev] [PATCH 1/3 v2] dat

Re: [ovs-dev] [PATCH 1/3 v2] datapath-windows: add netlink message parsing APIs

2014-08-22 Thread Saurabh Shah
Hey Ankur, Something to be careful of in future. You should wait for the reviewers to give an actual 'Acked-by' for a patch. If its a private Ack, it would be a good idea to mention it and then put an Ack for them. For example, Nithin & Samuel reviewed your V1 patch and gave comments, but that doe

[ovs-dev] [PATCH 1/3 v2] datapath-windows: add netlink message parsing APIs

2014-08-22 Thread Ankur Sharma
In this change we introduce Netlink.c, Netlink.h and NetlinkProto.h in datapath-windows. These files will provide netlink message data structures and parsing APIs. Changes are on similar lines to userspace netlink code. We have mapped the userspace APIs and data structures to kernel coding conve