Re: [ovs-dev] [PATCH 1/3] ofproto-dpif: Hide struct rule_dpif internally.

2013-09-04 Thread Ethan Jackson
I made that change, thanks for the review. Ethan On Wed, Sep 4, 2013 at 2:31 PM, Ben Pfaff wrote: > On Wed, Sep 04, 2013 at 12:37:34PM -0700, Ethan Jackson wrote: >> By hiding struct rule_dpif inside ofproto-dpif, it becomes very clear >> which attributes are accessed by multiple threads and nee

Re: [ovs-dev] [PATCH 1/3] ofproto-dpif: Hide struct rule_dpif internally.

2013-09-04 Thread Ben Pfaff
On Wed, Sep 04, 2013 at 12:37:34PM -0700, Ethan Jackson wrote: > By hiding struct rule_dpif inside ofproto-dpif, it becomes very clear > which attributes are accessed by multiple threads and need to be > protected by locks. > > Signed-off-by: Ethan Jackson I'd prefer for the rule_dpif function n

[ovs-dev] [PATCH 1/3] ofproto-dpif: Hide struct rule_dpif internally.

2013-09-04 Thread Ethan Jackson
By hiding struct rule_dpif inside ofproto-dpif, it becomes very clear which attributes are accessed by multiple threads and need to be protected by locks. Signed-off-by: Ethan Jackson --- ofproto/ofproto-dpif-upcall.c |2 +- ofproto/ofproto-dpif-xlate.c | 23 +++--- ofproto/ofprot