On Thu, Sep 13, 2012 at 09:28:50PM -0700, Ben Pfaff wrote:
> On Fri, Sep 14, 2012 at 12:05:44PM +0900, Simon Horman wrote:
> > On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote:
> > > I get rejects on this against commit 307975da7 currently on master.
> > >
> > > As long as it needs a reba
On Fri, Sep 14, 2012 at 12:05:44PM +0900, Simon Horman wrote:
> On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote:
> > I get rejects on this against commit 307975da7 currently on master.
> >
> > As long as it needs a rebase anyhow, I see a few more changes I'd
> > like:
> >
> > *
On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote:
> I get rejects on this against commit 307975da7 currently on master.
>
> As long as it needs a rebase anyhow, I see a few more changes I'd
> like:
>
> * The struct ofp12_action_set_field change looks good but the
> line
On Thu, Sep 13, 2012 at 01:06:09PM -0700, Ben Pfaff wrote:
> * What's the "nast" in set_field_to_nast() stand for? nxast
> stands for "Nicira eXtension Action Type", but
> set-field isn't a Nicira extension.
s//Sub/ I guess.
___
I get rejects on this against commit 307975da7 currently on master.
As long as it needs a rebase anyhow, I see a few more changes I'd
like:
* The struct ofp12_action_set_field change looks good but the
line "- Exactly oxm_len bytes containing a single OXM TLV,
then" in
From: Isaku Yamahata
Signed-off-by: Isaku Yamahata
Signed-off-by: Simon Horman
---
v6 [Simon Horman]
* Change ofp12_action_set_field so that the last element is
ovs_be32 dst rather than uint8_t field[4].
This avoids some casting when the field is used.
* Use is_all_zeros()
* Accept non-OX
