FWIW, I removed the two "megaflow" references in my code and replaced them with
"kernel wildcards".
--Justin
On Jun 6, 2013, at 5:17 PM, Jesse Gross wrote:
> I mostly meant the kernel code since that's what I've been looking at
> but would be good to be consistent throughout the code base. I
I mostly meant the kernel code since that's what I've been looking at
but would be good to be consistent throughout the code base. I think
there are just a few instances of the term in the userspace code and
if we think the term in not obvious then it might be better to just
use "wildcard" or some
Thanks, I will address this point in V2 patch.
I agree with you to remove it from the other locations, but want to make
sure you meant within the scope of kernel code, right?
Andy
On Thu, Jun 6, 2013 at 4:41 PM, Jesse Gross wrote:
> It looks good - I might also add that if the mask attribute
It looks good - I might also add that if the mask attribute is not
specified at all then the flow is exact match. I agree that it is
probably clearer to not use the term "mega flow" here but we should
then also remove it from the other locations in the code as well.
On Thu, Jun 6, 2013 at 3:15 PM,
How about the following change? I choose not to use the term "mega flow"
here to avoid confusing outside people.
diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
index 6e71b4c..203c7eb 100644
--- a/include/linux/openvswitch.h
+++ b/include/linux/openvswitch.h
@@ -410,9 +410,1
On Wed, Jun 5, 2013 at 10:46 PM, Andy Zhou wrote:
> diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
> index e890fd8..6e71b4c 100644
> --- a/include/linux/openvswitch.h
> +++ b/include/linux/openvswitch.h
> @@ -410,6 +410,9 @@ struct ovs_key_nd {
> * @OVS_FLOW_ATTR_CLEAR: I
This patch is required for subsequent mega flow patchs.
Signed-off-by: Andy Zhou
---
include/linux/openvswitch.h |4
1 file changed, 4 insertions(+)
diff --git a/include/linux/openvswitch.h b/include/linux/openvswitch.h
index e890fd8..6e71b4c 100644
--- a/include/linux/openvswitch.h
++
