Re: [ovs-dev] [PATCH 1/3] dpif: Allow execute to modify the packet.

2013-12-16 Thread Jarno Rajahalme
Pushed, thanks! I corrected a typo in a comment (“alloed” -> “allowed”), which breaks the next patch in the series. The resolution is trivial, so I’d rather not send out a new version if not needed otherwise. Jarno On Dec 13, 2013, at 3:59 PM, Ben Pfaff wrote: > On Fri, Nov 15, 2013 at 03:

Re: [ovs-dev] [PATCH 1/3] dpif: Allow execute to modify the packet.

2013-12-13 Thread Ben Pfaff
On Fri, Nov 15, 2013 at 03:12:18PM -0800, Jarno Rajahalme wrote: > Allowing the packet to be modified by execution allows less data > copying for userspace action execution. Some users of the > dpif_execute already expect that the packet may be modified. This > patch makes this behavior uniform a

Re: [ovs-dev] [PATCH 1/3] dpif: Allow execute to modify the packet.

2013-11-21 Thread Ben Pfaff
On Thu, Nov 21, 2013 at 02:36:59PM -0800, Jarno Rajahalme wrote: > > On Nov 21, 2013, at 1:55 PM, Ben Pfaff wrote: > > > On Fri, Nov 15, 2013 at 03:12:18PM -0800, Jarno Rajahalme wrote: > >> Allowing the packet to be modified by execution allows less data > >> copying for userspace action execut

Re: [ovs-dev] [PATCH 1/3] dpif: Allow execute to modify the packet.

2013-11-21 Thread Jarno Rajahalme
On Nov 21, 2013, at 1:55 PM, Ben Pfaff wrote: > On Fri, Nov 15, 2013 at 03:12:18PM -0800, Jarno Rajahalme wrote: >> Allowing the packet to be modified by execution allows less data >> copying for userspace action execution. Some users of the >> dpif_execute already expect that the packet may be

Re: [ovs-dev] [PATCH 1/3] dpif: Allow execute to modify the packet.

2013-11-21 Thread Ben Pfaff
On Fri, Nov 15, 2013 at 03:12:18PM -0800, Jarno Rajahalme wrote: > Allowing the packet to be modified by execution allows less data > copying for userspace action execution. Some users of the > dpif_execute already expect that the packet may be modified. This > patch makes this behavior uniform a

[ovs-dev] [PATCH 1/3] dpif: Allow execute to modify the packet.

2013-11-15 Thread Jarno Rajahalme
Allowing the packet to be modified by execution allows less data copying for userspace action execution. Some users of the dpif_execute already expect that the packet may be modified. This patch makes this behavior uniform and makes the userspace datapath and the execution helpers modify the pack