Re: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs (Ankur Sharma)

2014-08-22 Thread Samuel Ghinet
dev@openvswitch.org Subject: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs Message-ID: <1408553162-8021-1-git-send-email-ankursha...@vmware.com> In this change we introduce Netlink.c, Netlink.h and NetlinkProto.h in datapath-windows. These files will provide

Re: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs (Ankur Sharma)

2014-08-21 Thread Ankur Sharma
and replace it with MAXUINT32? Sam Date: Wed, 20 Aug 2014 09:46:02 -0700 From: Ankur Sharma To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs Message-ID: <1408553162-8021-1-git-send-email

Re: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs (Ankur Sharma)

2014-08-21 Thread Samuel Ghinet
and replace it with MAXUINT32? Sam Date: Wed, 20 Aug 2014 09:46:02 -0700 From: Ankur Sharma To: dev@openvswitch.org Subject: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs Message-ID: <1408553162-8021-1-git-send-email

Re: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs

2014-08-21 Thread Nithin Raju
Ankur, Thanks for working on this. I had the following overall comments. I have annotated the patch with specific comments as appropriate. I didn't realize initially that the Netlink.c, Netlink.h that you are introducing have major modifications compared to the userspace netlink.c and netlink.h

Re: [ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs

2014-08-20 Thread Saurabh Shah
>In this change we introduce Netlink.c, Netlink.h and NetlinkProto.h >in datapath-windows. These files will provide netlink message >data structures and parsing APIs. > >Changes are on similar lines to userspace netlink code. > >Change-Id: Ic225504eff3a25c0619ce3b27d8f54155d8af409 Not a review. I

[ovs-dev] [PATCH 1/3] datapath-windows: add netlink message parsing APIs

2014-08-20 Thread Ankur Sharma
In this change we introduce Netlink.c, Netlink.h and NetlinkProto.h in datapath-windows. These files will provide netlink message data structures and parsing APIs. Changes are on similar lines to userspace netlink code. Change-Id: Ic225504eff3a25c0619ce3b27d8f54155d8af409 Signed-off-by: Ankur Sha