Re: [ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-19 Thread Simon Horman
On Thu, Jul 19, 2012 at 08:51:30AM -0700, Ben Pfaff wrote: > On Thu, Jul 19, 2012 at 08:43:16AM -0700, Ben Pfaff wrote: > > On Thu, Jul 19, 2012 at 03:27:58PM +0900, Simon Horman wrote: > > > On Thu, Jul 19, 2012 at 10:08:50AM +0900, Simon Horman wrote: > > > > On Wed, Jul 18, 2012 at 10:21:50AM -0

Re: [ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-19 Thread Ben Pfaff
On Thu, Jul 19, 2012 at 08:43:16AM -0700, Ben Pfaff wrote: > On Thu, Jul 19, 2012 at 03:27:58PM +0900, Simon Horman wrote: > > On Thu, Jul 19, 2012 at 10:08:50AM +0900, Simon Horman wrote: > > > On Wed, Jul 18, 2012 at 10:21:50AM -0700, Ben Pfaff wrote: > > > > On Wed, Jul 18, 2012 at 12:02:19PM +0

Re: [ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-19 Thread Ben Pfaff
On Thu, Jul 19, 2012 at 03:27:58PM +0900, Simon Horman wrote: > On Thu, Jul 19, 2012 at 10:08:50AM +0900, Simon Horman wrote: > > On Wed, Jul 18, 2012 at 10:21:50AM -0700, Ben Pfaff wrote: > > > On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote: > > > > Signed-off-by: Simon Horman > > >

Re: [ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-18 Thread Simon Horman
On Thu, Jul 19, 2012 at 10:08:50AM +0900, Simon Horman wrote: > On Wed, Jul 18, 2012 at 10:21:50AM -0700, Ben Pfaff wrote: > > On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote: > > > Signed-off-by: Simon Horman > > > > When I apply this to master (currently 333be161abe78), I get the >

Re: [ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-18 Thread Simon Horman
On Wed, Jul 18, 2012 at 10:21:50AM -0700, Ben Pfaff wrote: > On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > When I apply this to master (currently 333be161abe78), I get the > following test failure. It isn't immediately obvious to me why this >

Re: [ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-18 Thread Ben Pfaff
On Wed, Jul 18, 2012 at 12:02:19PM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman When I apply this to master (currently 333be161abe78), I get the following test failure. It isn't immediately obvious to me why this change should have an effect on dl_vlan_pcp, so I'll leave it to you to

[ovs-dev] [PATCH 1/3] OXM: Allow masking of IPv6 Flow Label

2012-07-17 Thread Simon Horman
Signed-off-by: Simon Horman --- v3: * Saved masked label rather than raw label * Show mask if non-zero when formating rules v2: * Use MFM_FULL instead of a new mask-type for the lower 20 bits. This is to allow an all-one mask for all 32bits that are used to encode a Flow Label. * Increment