Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 09:26:19AM -0800, Bruce Davie wrote: > The processing for MPLS TTL is somewhat complex compared to IP, > because there are a few different options for what is acceptable > when pushing and popping labels. However, one thing that DOES carry > forward straightforwardly from IP

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Bruce Davie
The processing for MPLS TTL is somewhat complex compared to IP, because there are a few different options for what is acceptable when pushing and popping labels. However, one thing that DOES carry forward straightforwardly from IP is that if the TTL reaches zero, the packet MUST be discarded. Th

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 08:40:38AM -0800, Ben Pfaff wrote: > On Wed, Mar 06, 2013 at 08:29:13AM -0800, Jesse Gross wrote: > > On Wed, Mar 6, 2013 at 8:21 AM, Ben Pfaff wrote: > > > On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: > > >> On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wr

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 08:29:13AM -0800, Jesse Gross wrote: > On Wed, Mar 6, 2013 at 8:21 AM, Ben Pfaff wrote: > > On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: > >> On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: > >> > [ Cc Pravin B Shelar ] > >> > > >> > On Tue, Mar 05, 20

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Jesse Gross
On Wed, Mar 6, 2013 at 8:21 AM, Ben Pfaff wrote: > On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: >> On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: >> > [ Cc Pravin B Shelar ] >> > >> > On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: >> >> On Wed, Mar 06, 2013 at 10

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 07:46:16AM -0800, Jesse Gross wrote: > On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: > > [ Cc Pravin B Shelar ] > > > > On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: > >> On Wed, Mar 06, 2013 at 10:42:02AM +0900, Simon Horman wrote: > >> > On Tue, Mar 05

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-06 Thread Jesse Gross
On Tue, Mar 5, 2013 at 11:08 PM, Simon Horman wrote: > [ Cc Pravin B Shelar ] > > On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: >> On Wed, Mar 06, 2013 at 10:42:02AM +0900, Simon Horman wrote: >> > On Tue, Mar 05, 2013 at 10:14:44AM -0800, Ben Pfaff wrote: >> > > On Thu, Feb 28, 2013

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-05 Thread Simon Horman
[ Cc Pravin B Shelar ] On Tue, Mar 05, 2013 at 06:11:27PM -0800, Ben Pfaff wrote: > On Wed, Mar 06, 2013 at 10:42:02AM +0900, Simon Horman wrote: > > On Tue, Mar 05, 2013 at 10:14:44AM -0800, Ben Pfaff wrote: > > > On Thu, Feb 28, 2013 at 06:15:07PM +0900, Simon Horman wrote: > > > > This adds sup

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-05 Thread Ben Pfaff
On Wed, Mar 06, 2013 at 10:42:02AM +0900, Simon Horman wrote: > On Tue, Mar 05, 2013 at 10:14:44AM -0800, Ben Pfaff wrote: > > On Thu, Feb 28, 2013 at 06:15:07PM +0900, Simon Horman wrote: > > > This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. > > > And also adds an NX dec_mpls_ttl acti

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-05 Thread Simon Horman
On Tue, Mar 05, 2013 at 10:14:44AM -0800, Ben Pfaff wrote: > On Thu, Feb 28, 2013 at 06:15:07PM +0900, Simon Horman wrote: > > This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. > > And also adds an NX dec_mpls_ttl action. > > > > The handling of the TTL modification is entirely handled

Re: [ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-03-05 Thread Ben Pfaff
On Thu, Feb 28, 2013 at 06:15:07PM +0900, Simon Horman wrote: > This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. > And also adds an NX dec_mpls_ttl action. > > The handling of the TTL modification is entirely handled in userspace. > > Reviewed-by: Isaku Yamahata > Signed-off-by: Simo

[ovs-dev] [PATCH 1/3] Add support for dec_mpls_ttl action

2013-02-28 Thread Simon Horman
This adds support for the OpenFlow 1.1+ dec_mpls_ttl action. And also adds an NX dec_mpls_ttl action. The handling of the TTL modification is entirely handled in userspace. Reviewed-by: Isaku Yamahata Signed-off-by: Simon Horman --- v2.18 - v2.19 * No change v2.17 * Rebase * As suggested by