Re: [ovs-dev] [PATCH 1/3] Add error codes for Open Flow v1.2

2012-03-22 Thread Ben Pfaff
On Thu, Mar 22, 2012 at 04:58:53PM +0900, Simon Horman wrote: > On Tue, Mar 20, 2012 at 10:28:02AM -0700, Ben Pfaff wrote: > > On Tue, Mar 20, 2012 at 11:43:38AM +0900, Simon Horman wrote: > > > On Mon, Mar 19, 2012 at 02:31:36PM -0700, Ben Pfaff wrote: > > > > On Mon, Mar 19, 2012 at 09:54:43AM +0

Re: [ovs-dev] [PATCH 1/3] Add error codes for Open Flow v1.2

2012-03-22 Thread Simon Horman
On Tue, Mar 20, 2012 at 10:28:02AM -0700, Ben Pfaff wrote: > On Tue, Mar 20, 2012 at 11:43:38AM +0900, Simon Horman wrote: > > On Mon, Mar 19, 2012 at 02:31:36PM -0700, Ben Pfaff wrote: > > > On Mon, Mar 19, 2012 at 09:54:43AM +0900, Simon Horman wrote: [snip] > > > Second, in a few cases OF1.2 s

Re: [ovs-dev] [PATCH 1/3] Add error codes for Open Flow v1.2

2012-03-20 Thread Ben Pfaff
On Tue, Mar 20, 2012 at 11:43:38AM +0900, Simon Horman wrote: > On Mon, Mar 19, 2012 at 02:31:36PM -0700, Ben Pfaff wrote: > > On Mon, Mar 19, 2012 at 09:54:43AM +0900, Simon Horman wrote: > > > Signed-off-by: Simon Horman > > > > This looks good to me with a few comments. > > > > The meanings o

Re: [ovs-dev] [PATCH 1/3] Add error codes for Open Flow v1.2

2012-03-19 Thread Simon Horman
On Mon, Mar 19, 2012 at 02:31:36PM -0700, Ben Pfaff wrote: > On Mon, Mar 19, 2012 at 09:54:43AM +0900, Simon Horman wrote: > > Signed-off-by: Simon Horman > > This looks good to me with a few comments. > > The meanings of the little abbreviations we use for OpenFlow versions > are starting to ge

Re: [ovs-dev] [PATCH 1/3] Add error codes for Open Flow v1.2

2012-03-19 Thread Ben Pfaff
On Mon, Mar 19, 2012 at 09:54:43AM +0900, Simon Horman wrote: > Signed-off-by: Simon Horman This looks good to me with a few comments. The meanings of the little abbreviations we use for OpenFlow versions are starting to get a bit more complex, so it's probably a good idea to include a "key" in

[ovs-dev] [PATCH 1/3] Add error codes for Open Flow v1.2

2012-03-18 Thread Simon Horman
Signed-off-by: Simon Horman --- build-aux/extract-ofp-errors | 23 ++--- lib/ofp-errors.h | 101 +- 2 files changed, 115 insertions(+), 9 deletions(-) diff --git a/build-aux/extract-ofp-errors b/build-aux/extract-ofp-errors index 5c3cd26