Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-25 Thread Ben Pfaff
On Thu, Jun 25, 2015 at 02:33:33PM +, Alin Serdean wrote: > I am ok with the concept and I will test it if you send a patch out. OK, here you go: http://openvswitch.org/pipermail/dev/2015-June/056859.html ___ dev mailing list dev@openvswitch.

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-25 Thread Alin Serdean
: Thursday, June 25, 2015 3:17 AM Către: Gurucharan Shetty Cc: Alin Serdean; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests On Wed, Jun 24, 2015 at 07:49:08AM -0700, Gurucharan Shetty wrote: > You can look at "commit 5e65e080ad4d57e&q

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-24 Thread Ben Pfaff
On Wed, Jun 24, 2015 at 07:49:08AM -0700, Gurucharan Shetty wrote: > You can look at "commit 5e65e080ad4d57e" for more information on the > exact problem with taskkill. > > One option is to check for tskill and if it does not exist, use taskkill. Here's a concept for that, it's probably buggy bec

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-24 Thread Gurucharan Shetty
lto:shet...@nicira.com] > Trimis: Tuesday, June 23, 2015 5:40 PM > Către: Alin Serdean > Cc: dev@openvswitch.org > Subiect: Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests > > I applied this patch as-is. We still need to figure out the issue around > tskill

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-23 Thread Alin Serdean
@nicira.com] Trimis: Tuesday, June 23, 2015 5:40 PM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests I applied this patch as-is. We still need to figure out the issue around tskill. On Tue, Jun 23, 2015 at 7:05 AM, Gurucharan She

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-23 Thread Gurucharan Shetty
I applied this patch as-is. We still need to figure out the issue around tskill. On Tue, Jun 23, 2015 at 7:05 AM, Gurucharan Shetty wrote: > On Mon, Jun 22, 2015 at 5:21 PM, Alin Serdean > wrote: >> I could send another patch with the following: >> -tskill $i >> +

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-23 Thread Gurucharan Shetty
On Mon, Jun 22, 2015 at 5:21 PM, Alin Serdean wrote: > I could send another patch with the following: > -tskill $i > +taskkill //PID $i //F >/dev/null > > Alin. Your current patch is something that I think we should apply because from Windows' persp

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Alin Serdean
dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean wrote: > On Windows the following tests hang unless we also call the > OVS_VSWITCHD_STOP macro to stop the executable. This concerns me

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Alin Serdean
Subiect: Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean wrote: > On Windows the following tests hang unless we also call the > OVS_VSWITCHD_STOP macro to stop the executable. This concerns me a bit. In _OVS_VSWITCHD_START, w

Re: [ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Gurucharan Shetty
On Mon, Jun 22, 2015 at 3:45 PM, Alin Serdean wrote: > On Windows the following tests hang unless we also call > the OVS_VSWITCHD_STOP macro to stop the executable. This concerns me a bit. In _OVS_VSWITCHD_START, we call ON_EXIT_UNQUOTED([kill `cat ovs-vswitchd.pid`]) ON_EXIT_UNQUOTED([kill `cat

[ovs-dev] [PATCH 1/3] Add OVS_VSWITCHD_STOP to bfd unit tests

2015-06-22 Thread Alin Serdean
On Windows the following tests hang unless we also call the OVS_VSWITCHD_STOP macro to stop the executable. Tested on Windows and Linux Signed-off-by: Alin Gabriel Serdean --- tests/bfd.at | 4 1 file changed, 4 insertions(+) diff --git a/tests/bfd.at b/tests/bfd.at index 8bf88f2..5215d2e