Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-19 Thread Alin Serdean
No worries. Take your time :). Alin. -Mesaj original- De la: Nithin Raju [mailto:nit...@vmware.com] Trimis: Friday, June 19, 2015 10:01 PM Către: Alin Serdean Cc: dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c > On

Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-19 Thread Nithin Raju
> On Jun 19, 2015, at 11:55 AM, Alin Serdean > wrote: > > Hi Nithin, > > Thanks for the patch! > > I managed to hit the assert again. > > Child-SP RetAddr Call Site > d001`7b8db7f0 f801`4446530b nt!RtlAssert+0xeb > d001`7b8dbd50 f801`444620df OVSExt!OvsRemov

Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-19 Thread Alin Serdean
Către: Nithin Raju; dev@openvswitch.org Subiect: Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c Hi Nithin, Thanks for the patch! I managed to hit the assert again. Child-SP RetAddr Call Site d001`7b8db7f0 f801`4446530b nt!RtlAssert

Re: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-19 Thread Alin Serdean
[mailto:dev-boun...@openvswitch.org] În numele Nithin Raju Trimis: Friday, June 19, 2015 8:13 AM Către: dev@openvswitch.org Subiect: [ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c In this patch, there a couple of fixes and some code refactoring: 1. During deletion

[ovs-dev] [PATCH 1/2 v2] datapath-windows: Code refactoring and fixes in Vport.c

2015-06-18 Thread Nithin Raju
In this patch, there a couple of fixes and some code refactoring: 1. During deletion of "internal" and "external" in OvsRemoveAndDeleteVport(), we need to check if 'hvDelete' is TRUE before updating the data structures. Added code comments explaining the same. 2. Added a OvsRemoveTunnelPo