Re: [ovs-dev] [PATCH 1/2] vswitchd: Remove unused 'tag' from 'struct iface'.

2012-04-23 Thread Ben Pfaff
OK, great, thanks for looking into it. On Mon, Apr 23, 2012 at 11:15:28AM -0700, Ethan Jackson wrote: > Looking through the code, it hasn't been used since switching was > moved from the bridge into ofproto-dpif as suspected. > > Ethan > > On Mon, Apr 23, 2012 at 11:09, Ethan Jackson wrote: > >

Re: [ovs-dev] [PATCH 1/2] vswitchd: Remove unused 'tag' from 'struct iface'.

2012-04-23 Thread Ethan Jackson
Looking through the code, it hasn't been used since switching was moved from the bridge into ofproto-dpif as suspected. Ethan On Mon, Apr 23, 2012 at 11:09, Ethan Jackson wrote: > I had assumed that it's left over from when the bridge did bonding and > learning.  I'll look through the commit his

Re: [ovs-dev] [PATCH 1/2] vswitchd: Remove unused 'tag' from 'struct iface'.

2012-04-23 Thread Ethan Jackson
I had assumed that it's left over from when the bridge did bonding and learning. I'll look through the commit history to verify. Ethan On Mon, Apr 23, 2012 at 09:18, Ben Pfaff wrote: > This looks good but did you look back to figure out what we had been > using this for and whether it was truly

Re: [ovs-dev] [PATCH 1/2] vswitchd: Remove unused 'tag' from 'struct iface'.

2012-04-23 Thread Ben Pfaff
This looks good but did you look back to figure out what we had been using this for and whether it was truly no longer needed? Thanks, Ben. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/2] vswitchd: Remove unused 'tag' from 'struct iface'.

2012-04-22 Thread Ethan Jackson
--- vswitchd/bridge.c |2 -- 1 file changed, 2 deletions(-) diff --git a/vswitchd/bridge.c b/vswitchd/bridge.c index f4a10e6..15f6cb7 100644 --- a/vswitchd/bridge.c +++ b/vswitchd/bridge.c @@ -66,7 +66,6 @@ struct iface { struct hmap_node name_node; /* In struct bridge's "iface_by_name"