Re: [ovs-dev] [PATCH 1/2] python: Honor zero probe interval in reconnect.py

2012-04-13 Thread Ethan Jackson
Sure I'll send a separate patch. Ethan On Fri, Apr 13, 2012 at 16:40, Ben Pfaff wrote: > In that case then can you make the corresponding change in > lib/reconnect.c also? > > On Fri, Apr 13, 2012 at 03:57:20PM -0700, Ethan Jackson wrote: >> Yes it appears to fix the problem according to the un

Re: [ovs-dev] [PATCH 1/2] python: Honor zero probe interval in reconnect.py

2012-04-13 Thread Ben Pfaff
In that case then can you make the corresponding change in lib/reconnect.c also? On Fri, Apr 13, 2012 at 03:57:20PM -0700, Ethan Jackson wrote: > Yes it appears to fix the problem according to the unit tests. It > seems correct to fix it in both places to me though. > > Ethan > > On Fri, Apr 13

Re: [ovs-dev] [PATCH 1/2] python: Honor zero probe interval in reconnect.py

2012-04-13 Thread Ethan Jackson
Yes it appears to fix the problem according to the unit tests. It seems correct to fix it in both places to me though. Ethan On Fri, Apr 13, 2012 at 15:53, Ben Pfaff wrote: > On Wed, Apr 11, 2012 at 10:02:09PM -0700, Ethan Jackson wrote: >> The python reconnect library attempted to send a probe

Re: [ovs-dev] [PATCH 1/2] python: Honor zero probe interval in reconnect.py

2012-04-13 Thread Ben Pfaff
On Wed, Apr 11, 2012 at 10:02:09PM -0700, Ethan Jackson wrote: > The python reconnect library attempted to send a probe every 0 > milliseconds instead of disabling probing when the probe_interval > was zero. > > Signed-off-by: Ethan Jackson I think that this changes the Idle state so that, if th

[ovs-dev] [PATCH 1/2] python: Honor zero probe interval in reconnect.py

2012-04-13 Thread Ethan Jackson
The python reconnect library attempted to send a probe every 0 milliseconds instead of disabling probing when the probe_interval was zero. Signed-off-by: Ethan Jackson --- python/ovs/reconnect.py |8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/python/ovs/reconnect.