Re: [ovs-dev] [PATCH 1/2] netdev-linux: Use unsigned int for ifi_flags

2014-01-08 Thread Helmut Schaa
On Thu, Jan 9, 2014 at 1:09 AM, Ben Pfaff wrote: > On Wed, Jan 08, 2014 at 04:43:46PM +0100, Helmut Schaa wrote: >> ifi_flags is unsigned, the local equivalents should do the same. >> >> Signed-off-by: Helmut Schaa > > In the GNU C library, ifru_flags in struct ifreq, in net/if.h, has > type shor

Re: [ovs-dev] [PATCH 1/2] netdev-linux: Use unsigned int for ifi_flags

2014-01-08 Thread Ben Pfaff
On Wed, Jan 08, 2014 at 04:43:46PM +0100, Helmut Schaa wrote: > ifi_flags is unsigned, the local equivalents should do the same. > > Signed-off-by: Helmut Schaa In the GNU C library, ifru_flags in struct ifreq, in net/if.h, has type short int. I see that netdev-linux.c uses 'int' and 'unsigned

[ovs-dev] [PATCH 1/2] netdev-linux: Use unsigned int for ifi_flags

2014-01-08 Thread Helmut Schaa
ifi_flags is unsigned, the local equivalents should do the same. Signed-off-by: Helmut Schaa --- Otherwise the follow-up patch throws a warning during conmpilation. lib/netdev-linux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c in