Re: [ovs-dev] [PATCH 1/2] netdev-linux: Introduce netdev_linux_ethtool_set_flag().

2011-08-29 Thread Justin Pettit
On Aug 29, 2011, at 7:13 AM, Jesse Gross wrote: > On Aug 29, 2011 3:56 PM, "Justin Pettit" wrote: > > > > There will be a caller added soon. > > Looks good, thanks. Thanks. I'll push it when I get your ack on the next patch. --Justin ___ dev maili

Re: [ovs-dev] [PATCH 1/2] netdev-linux: Introduce netdev_linux_ethtool_set_flag().

2011-08-29 Thread Jesse Gross
On Aug 29, 2011 3:56 PM, "Justin Pettit" wrote: > > There will be a caller added soon. Looks good, thanks. ___ dev mailing list dev@openvswitch.org http://openvswitch.org/mailman/listinfo/dev

[ovs-dev] [PATCH 1/2] netdev-linux: Introduce netdev_linux_ethtool_set_flag().

2011-08-28 Thread Justin Pettit
There will be a caller added soon. --- lib/netdev-linux.c | 54 lib/netdev-linux.h |7 ++ 2 files changed, 61 insertions(+), 0 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 05b830c..838dac6 100644 --- a/lib/n

Re: [ovs-dev] [PATCH 1/2] netdev-linux: Introduce netdev_linux_ethtool_set_flag().

2011-08-18 Thread Justin Pettit
On Aug 18, 2011, at 9:28 AM, Ben Pfaff wrote: > Regarding ETHTOOL_GFLAGS and ETHTOOL_SFLAGS, usually I add #ifndef > around definitions for macros that might be defined in system headers. > I guess that it's unlikely that these would be defined differently in > system header, though. That's fair.

Re: [ovs-dev] [PATCH 1/2] netdev-linux: Introduce netdev_linux_ethtool_set_flag().

2011-08-18 Thread Ben Pfaff
On Wed, Aug 17, 2011 at 07:01:53PM -0700, Justin Pettit wrote: > There will be a caller added soon. Regarding ETHTOOL_GFLAGS and ETHTOOL_SFLAGS, usually I add #ifndef around definitions for macros that might be defined in system headers. I guess that it's unlikely that these would be defined diffe

[ovs-dev] [PATCH 1/2] netdev-linux: Introduce netdev_linux_ethtool_set_flag().

2011-08-17 Thread Justin Pettit
There will be a caller added soon. --- lib/netdev-linux.c | 28 lib/netdev-linux.h |8 2 files changed, 36 insertions(+), 0 deletions(-) diff --git a/lib/netdev-linux.c b/lib/netdev-linux.c index 05b830c..409f8b9 100644 --- a/lib/netdev-linux.c +++ b/li