Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-21 Thread Jesse Gross
On Thu, Mar 21, 2013 at 5:41 PM, Simon Horman wrote: > I think that the way that actions are marshalled by execute_* functions > and then turned into ODP actions using commit_* has worked well for now > and serves to provide a reasonably minimal set of ODP actions. However > it is difficult to mak

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-21 Thread Simon Horman
On Wed, Mar 20, 2013 at 03:31:51PM -0700, Jesse Gross wrote: > On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > > * Update the order in which actions are committed and thus > > appear in the datapath such that MPLS actions appear after > > l3 and l4 (nw and port) actions. > > > > In th

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-20 Thread Jesse Gross
On Wed, Mar 20, 2013 at 6:18 AM, Simon Horman wrote: > * Update the order in which actions are committed and thus > appear in the datapath such that MPLS actions appear after > l3 and l4 (nw and port) actions. > > In the case where an mpls_push action is present it should ensure > that l3

[ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-20 Thread Simon Horman
* Update the order in which actions are committed and thus appear in the datapath such that MPLS actions appear after l3 and l4 (nw and port) actions. In the case where an mpls_push action is present it should ensure that l3 and l4 actions occur first, which seems logical as once a mpls_

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-20 Thread Simon Horman
On Tue, Mar 19, 2013 at 12:20:51PM -0700, Jesse Gross wrote: > On Tue, Mar 19, 2013 at 7:57 AM, Simon Horman wrote: > > On Tue, Mar 19, 2013 at 10:35:40AM +0900, Simon Horman wrote: > >> On Mon, Mar 18, 2013 at 08:54:49AM -0700, Jesse Gross wrote: > >> > On Mon, Mar 18, 2013 at 12:37 AM, Simon Hor

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-19 Thread Jesse Gross
On Tue, Mar 19, 2013 at 7:57 AM, Simon Horman wrote: > On Tue, Mar 19, 2013 at 10:35:40AM +0900, Simon Horman wrote: >> On Mon, Mar 18, 2013 at 08:54:49AM -0700, Jesse Gross wrote: >> > On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: >> > > * Update the order in which actions are committed

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-19 Thread Simon Horman
On Tue, Mar 19, 2013 at 10:35:40AM +0900, Simon Horman wrote: > On Mon, Mar 18, 2013 at 08:54:49AM -0700, Jesse Gross wrote: > > On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > > > * Update the order in which actions are committed and thus > > > appear in the datapath such that MPLS acti

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-18 Thread Simon Horman
On Mon, Mar 18, 2013 at 08:54:49AM -0700, Jesse Gross wrote: > On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > > * Update the order in which actions are committed and thus > > appear in the datapath such that MPLS actions appear after > > l3 and l4 (nw and port) actions. > > > > In t

Re: [ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-18 Thread Jesse Gross
On Mon, Mar 18, 2013 at 12:37 AM, Simon Horman wrote: > * Update the order in which actions are committed and thus > appear in the datapath such that MPLS actions appear after > l3 and l4 (nw and port) actions. > > In the case where an mpls_push action is present it should ensure > that l3

[ovs-dev] [PATCH 1/2] mpls: Allow l3 and l4 actions to prior to a push_mpls action

2013-03-18 Thread Simon Horman
* Update the order in which actions are committed and thus appear in the datapath such that MPLS actions appear after l3 and l4 (nw and port) actions. In the case where an mpls_push action is present it should ensure that l3 and l4 actions occur first, which seems logical as once a mpls_