Re: [ovs-dev] [PATCH 1/2] jsonrpc: Don't swallow errors in jsonrpc_transact_block().

2012-02-27 Thread Ethan Jackson
> Will you backport this? Summary of an offline discussion: I don't think the change needs to be backported because nothing in the code base uses jsonrpc to return a message in the 'error' field. Therefore it's not possible to hit the bug. The next patch in the series uses this functionality, so

Re: [ovs-dev] [PATCH 1/2] jsonrpc: Don't swallow errors in jsonrpc_transact_block().

2012-02-27 Thread Ben Pfaff
On Thu, Feb 16, 2012 at 04:57:16PM -0800, Ethan Jackson wrote: > If a server returned an error in response to a request, > jsonrpc_transact_block() would ignore it. This patch changes the > behavior and updates its callers to gracefully handle the > possibility. > > Signed-off-by: Ethan Jackson

[ovs-dev] [PATCH 1/2] jsonrpc: Don't swallow errors in jsonrpc_transact_block().

2012-02-17 Thread Ethan Jackson
If a server returned an error in response to a request, jsonrpc_transact_block() would ignore it. This patch changes the behavior and updates its callers to gracefully handle the possibility. Signed-off-by: Ethan Jackson --- lib/jsonrpc.c|8 +--- ovsdb/ovsdb-client.c | 43