Re: [ovs-dev] [PATCH 1/2] hash: Add hash_add64().

On Dec 29, 2014, at 2:12 PM, Ben Pfaff wrote: > On Wed, Dec 17, 2014 at 10:30:41AM -0800, Jarno Rajahalme wrote: >> Add support for adding 64-bit words to hashes. This will be used by >> subsequent patches. >> >> Signed-off-by: Jarno Rajahalme > > I noticed that hash_words64() takes a 64-bit

Re: [ovs-dev] [PATCH 1/2] hash: Add hash_add64().

Thanks for noticing this, should have tried a 32-bit build myself… Jarno On Dec 29, 2014, at 2:19 PM, Ben Pfaff wrote: > On Mon, Dec 29, 2014 at 02:12:14PM -0800, Ben Pfaff wrote: >> On Wed, Dec 17, 2014 at 10:30:41AM -0800, Jarno Rajahalme wrote: >>> Add support for adding 64-bit words to ha

Re: [ovs-dev] [PATCH 1/2] hash: Add hash_add64().

On Mon, Dec 29, 2014 at 02:12:14PM -0800, Ben Pfaff wrote: > On Wed, Dec 17, 2014 at 10:30:41AM -0800, Jarno Rajahalme wrote: > > Add support for adding 64-bit words to hashes. This will be used by > > subsequent patches. > > > > Signed-off-by: Jarno Rajahalme > > Other than that philosophical i

Re: [ovs-dev] [PATCH 1/2] hash: Add hash_add64().

On Wed, Dec 17, 2014 at 10:30:41AM -0800, Jarno Rajahalme wrote: > Add support for adding 64-bit words to hashes. This will be used by > subsequent patches. > > Signed-off-by: Jarno Rajahalme I noticed that hash_words64() takes a 64-bit basis (which is not new). That seems odd because it return

[ovs-dev] [PATCH 1/2] hash: Add hash_add64().

Add support for adding 64-bit words to hashes. This will be used by subsequent patches. Signed-off-by: Jarno Rajahalme --- lib/classifier-private.h |3 +-- lib/dpif-netdev.c|3 +-- lib/hash.h | 33 + ofproto/tunnel.c |4