This makes sense, thanks. This patch looks good to me,
___
dev mailing list
dev@openvswitch.org
http://openvswitch.org/mailman/listinfo/dev
More specifically, this code in bfd_process_packet() sees p->l7 == NULL
and does pointer arithmetic on NULL, which seems bad:
msg = ofpbuf_at(p, (uint8_t *)p->l7 - (uint8_t *)p->data, BFD_PACKET_LEN);
On Wed, Oct 16, 2013 at 02:20:15PM -0700, Alex Wang wrote:
> Have a question,
>
> function
Have a question,
function flow_compose() is called when we specify '-generate' option. in
that case, the packet will not have any l7 data. so, seem to me there is
no change to the output.
Thanks,
On Mon, Sep 30, 2013 at 2:47 PM, Ben Pfaff wrote:
> flow_extract() fills in ->l7 but flow_compo
flow_extract() fills in ->l7 but flow_compose() wasn't doing it, which
confused bfd_process_packet() when invoked via the ofproto/trace appctl
command.
Signed-off-by: Ben Pfaff
---
lib/flow.c |1 +
1 file changed, 1 insertion(+)
diff --git a/lib/flow.c b/lib/flow.c
index 0678c6f..7372e3b 10
