Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-14 Thread Ben Pfaff
On Tue, Jul 14, 2015 at 08:27:15AM -0700, Jesse Gross wrote: > On Tue, Jul 14, 2015 at 8:18 AM, Gurucharan Shetty wrote: > > On Mon, Jul 13, 2015 at 2:12 PM, Jesse Gross wrote: > >> On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty > >> wrote: > >>> MSVC 2013 does not like designated initializ

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-14 Thread Jesse Gross
On Tue, Jul 14, 2015 at 8:18 AM, Gurucharan Shetty wrote: > On Mon, Jul 13, 2015 at 2:12 PM, Jesse Gross wrote: >> On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty >> wrote: >>> MSVC 2013 does not like designated initializers when >>> structs are initialized inside structs. >>> >>> Signed-off

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-14 Thread Gurucharan Shetty
On Mon, Jul 13, 2015 at 2:12 PM, Jesse Gross wrote: > On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty wrote: >> MSVC 2013 does not like designated initializers when >> structs are initialized inside structs. >> >> Signed-off-by: Gurucharan Shetty > > This looks fine to me, although there are

Re: [ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-13 Thread Jesse Gross
On Fri, Jul 10, 2015 at 9:26 PM, Gurucharan Shetty wrote: > MSVC 2013 does not like designated initializers when > structs are initialized inside structs. > > Signed-off-by: Gurucharan Shetty This looks fine to me, although there are several other instances of this pattern in other places. Are t

[ovs-dev] [PATCH 1/2] dpif-netdev: Don't use designated initializers.

2015-07-10 Thread Gurucharan Shetty
MSVC 2013 does not like designated initializers when structs are initialized inside structs. Signed-off-by: Gurucharan Shetty --- lib/dpif-netdev.c | 24 +--- 1 file changed, 13 insertions(+), 11 deletions(-) diff --git a/lib/dpif-netdev.c b/lib/dpif-netdev.c index b53d52a