Re: [ovs-dev] [PATCH 1/2] datapath: fix a bug in SF_FLOW_KEY_PUT macro

2013-07-29 Thread Andy Zhou
Yes indeed. Will add to this patch. On Mon, Jul 29, 2013 at 9:46 AM, Jesse Gross wrote: > On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote: > > This bug will cause mask values to corrupt the flow key value. So far > > the bug has not showed up because we don't write mask value when > > there

Re: [ovs-dev] [PATCH 1/2] datapath: fix a bug in SF_FLOW_KEY_PUT macro

2013-07-29 Thread Jesse Gross
On Sat, Jul 27, 2013 at 10:27 PM, Andy Zhou wrote: > This bug will cause mask values to corrupt the flow key value. So far > the bug has not showed up because we don't write mask value when > there is no mask Netlink attributes. However, it needs to be fixed for > the next and future commits wher

[ovs-dev] [PATCH 1/2] datapath: fix a bug in SF_FLOW_KEY_PUT macro

2013-07-27 Thread Andy Zhou
This bug will cause mask values to corrupt the flow key value. So far the bug has not showed up because we don't write mask value when there is no mask Netlink attributes. However, it needs to be fixed for the next and future commits where we will start to set default values for key and mask for m