Re: [ovs-dev] [PATCH 1/2] bfd: Implements BFD decay

2013-07-12 Thread Alex Wang
Thanks Ethan, for the comments, On Fri, Jul 12, 2013 at 2:15 PM, Ethan Jackson wrote: > In bfd_run() the final if statement should run whether or not decay is > enabled. It will have to become a bit more sophisticated, but > assuming my suggestion in the previous patch works, it should be > st

Re: [ovs-dev] [PATCH 1/2] bfd: Implements BFD decay

2013-07-12 Thread Ethan Jackson
Thanks for getting this together. Comments below. Major stuff: When anything changes about the configuration of the decay feature, the decay_detect_time needs to be reset and we should switch back to the original min_rx. To be safe, I'd also reset it when the min_rx changes. I wouldn't bother

[ovs-dev] [PATCH 1/2] bfd: Implements BFD decay

2013-07-11 Thread Alex Wang
When there is no incoming data traffic in the tunnel for a period, BFD decay allows the bfd session to increase the min_rx. This is helpful in that usually some tunnels are rarely used. And cpu consumption can be reduced by processing fewer bfd control packets. Signed-off-by: Alex Wang --- lib/b