Re: [ovs-dev] [PATCH 1/2] bfd: Add forwarding flag to struct bfd.

2013-11-20 Thread Alex Wang
Thanks both of you for the comments, I'll adjust accordingly, On Wed, Nov 20, 2013 at 10:19 AM, Joe Stringer wrote: > On 15 November 2013 13:58, Alex Wang wrote: > > static uint64_t > > @@ -1081,6 +1088,8 @@ bfd_check_rx(struct bfd *bfd) OVS_REQUIRES(mutex) > > } > > if (bfd->forwar

Re: [ovs-dev] [PATCH 1/2] bfd: Add forwarding flag to struct bfd.

2013-11-20 Thread Joe Stringer
On 15 November 2013 13:58, Alex Wang wrote: > static uint64_t > @@ -1081,6 +1088,8 @@ bfd_check_rx(struct bfd *bfd) OVS_REQUIRES(mutex) > } > if (bfd->forwarding_if_rx && diff > 0) { > bfd_forwarding_if_rx_update(bfd); > +/* Updates the forwarding flag. */ > +bf

Re: [ovs-dev] [PATCH 1/2] bfd: Add forwarding flag to struct bfd.

2013-11-20 Thread Ben Pfaff
On Fri, Nov 15, 2013 at 01:58:24PM -0800, Alex Wang wrote: > This commit adds a forwarding flag to "struct bfd". And > bfd_forwarding__() will update this flag at each invocation. > > Signed-off-by: Alex Wang This seems reasonable but I'd think that the commit message should explain why adding

Re: [ovs-dev] [PATCH 1/2] bfd: Add forwarding flag to struct bfd.

2013-11-19 Thread Alex Wang
sorry please ignore the previous email... didn't intend to broadcast... sorry for the spam, On Tue, Nov 19, 2013 at 9:07 AM, Alex Wang wrote: > Every other day reminder~, could you review this patch~? thx > > > On Fri, Nov 15, 2013 at 1:58 PM, Alex Wang wrote: > >> This commit adds a forwardi

Re: [ovs-dev] [PATCH 1/2] bfd: Add forwarding flag to struct bfd.

2013-11-19 Thread Alex Wang
Every other day reminder~, could you review this patch~? thx On Fri, Nov 15, 2013 at 1:58 PM, Alex Wang wrote: > This commit adds a forwarding flag to "struct bfd". And > bfd_forwarding__() will update this flag at each invocation. > > Signed-off-by: Alex Wang > --- > lib/bfd.c | 30 ++

[ovs-dev] [PATCH 1/2] bfd: Add forwarding flag to struct bfd.

2013-11-15 Thread Alex Wang
This commit adds a forwarding flag to "struct bfd". And bfd_forwarding__() will update this flag at each invocation. Signed-off-by: Alex Wang --- lib/bfd.c | 30 +++--- lib/bfd.h |2 +- 2 files changed, 20 insertions(+), 12 deletions(-) diff --git a/lib/bfd.c b/li