Re: [ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-13 Thread Ben Pfaff
You're welcome. On Thu, Sep 12, 2013 at 07:03:51PM -0700, Paul Ingram wrote: > I just noticed that you fixed a silly error in ovsdb/ovsdb-tool.c that > I introduced in my original patch. > > Thanks for that > > :: psi > > On Sep 12, 2013, at 6:23 PM, Paul Ingram wrote: > > > On Sep 11, 2013,

Re: [ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-13 Thread Ben Pfaff
On Thu, Sep 12, 2013 at 06:23:22PM -0700, Paul Ingram wrote: > On Sep 11, 2013, at 10:39 PM, Ben Pfaff wrote: > > > It's reasonable enough. > > > > I didn't really like the %. format specification for this. It is > > inflexible--what if someone wants only tenths of a second or wants > > microse

Re: [ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-12 Thread Paul Ingram
I just noticed that you fixed a silly error in ovsdb/ovsdb-tool.c that I introduced in my original patch. Thanks for that :: psi On Sep 12, 2013, at 6:23 PM, Paul Ingram wrote: > On Sep 11, 2013, at 10:39 PM, Ben Pfaff wrote: > >> It's reasonable enough. >> >> I didn't really like the %.

Re: [ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-12 Thread Paul Ingram
On Sep 11, 2013, at 10:39 PM, Ben Pfaff wrote: > It's reasonable enough. > > I didn't really like the %. format specification for this. It is > inflexible--what if someone wants only tenths of a second or wants > microseconds? It is also somewhat hard to parse since it uses % > (naturally enou

Re: [ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-11 Thread Ben Pfaff
On Mon, Sep 09, 2013 at 06:05:42PM -0700, Paul Ingram wrote: > To make debugging easier. It's reasonable enough. I didn't really like the %. format specification for this. It is inflexible--what if someone wants only tenths of a second or wants microseconds? It is also somewhat hard to parse si

[ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-09 Thread Paul Ingram
To make debugging easier. --- lib/dynamic-string.c | 21 +++-- lib/dynamic-string.h |7 ++--- lib/table.c |2 +- lib/timeval.c | 79 + lib/timeval.h |9 ++ lib/vlog.c| 16 +

[ovs-dev] [PATCH 1/2] Report timestamps in millisecond resolution in log messages.

2013-09-08 Thread Paul Ingram
To make debugging easier. --- lib/dynamic-string.c | 21 +++-- lib/dynamic-string.h |7 ++--- lib/table.c |2 +- lib/timeval.c | 79 + lib/timeval.h |9 ++ lib/vlog.c| 16 +