Re: [ovs-dev] [PATCH 1/2] Committing two issues:

2015-06-25 Thread Garg, Sumit
Hello Ben, no worries. Still figuring my way around git, github etc. So, please excuse by missteps (e.g. subject lines). I've redone (revert + recommit) changes to my fork with a better commit message. Will, be sending the patch (via email) & pull request (via github) shortly. Let's handle the

Re: [ovs-dev] [PATCH 1/2] Committing two issues:

2015-06-24 Thread Ben Pfaff
Hi Sumit. Sorry it took me a while to review this--I'm catching up as best I can. Can I have a Signed-off-by for this commit? CONTRIBUTING.md says this about Signed-off-by: Signed-off-by: Author Name Informally, this indicates that Author Name is the author or submitter of

[ovs-dev] [PATCH 1/2] Committing two issues:

2015-06-20 Thread Ben Pfaff
From: Sumit Garg 1. A bool (has_lock) was being accessed as a function call leading to a runtime exception. 2. When 'alert' was turned off on a column, the code was erroring out when value for that column was being set in a newly inserted row. This is because the row._data was None a