Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Ben Pfaff
On Wed, Feb 15, 2012 at 05:38:28PM +, Dominic Curran wrote: > > -Original Message- > > From: Ben Pfaff [mailto:b...@nicira.com] > > Sent: 15 February 2012 17:24 > > To: Rob Hoes > > Cc: dev@openvswitch.org; Dominic Curran; Rob Hoes > > Subject: Re:

Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Dominic Curran
> -Original Message- > From: Ben Pfaff [mailto:b...@nicira.com] > Sent: 15 February 2012 17:24 > To: Rob Hoes > Cc: dev@openvswitch.org; Dominic Curran; Rob Hoes > Subject: Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of > dictionary > > On Wed, Feb 15, 20

Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Ben Pfaff
On Wed, Feb 15, 2012 at 05:17:25PM +, Rob Hoes wrote: > From: Dominic Curran > > Fix bug in commit 3249bb907a1dab9b0 > > Incorrectly assume that get_all_records_where() returned a list. > It infact returns a disctionary and the list iteratory needs to change > to account for this. > Thanks t

[ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Rob Hoes
From: Dominic Curran Fix bug in commit 3249bb907a1dab9b0 Incorrectly assume that get_all_records_where() returned a list. It infact returns a disctionary and the list iteratory needs to change to account for this. Thanks to Nicira for pointing this out. NIC-454. Signed-off-by: Rob Hoes Report

Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Jesse Gross
On Wed, Feb 15, 2012 at 8:56 AM, Ben Pfaff wrote: > On Wed, Feb 15, 2012 at 04:59:31PM +, Dominic Curran wrote: >> Fix bug in commit 3249bb907a1dab9b0 >> >> Incorrectly assume that get_all_records_where() returned a list. >> It infact returns a disctionary and the list iteratory needs to chang

Re: [ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Ben Pfaff
On Wed, Feb 15, 2012 at 04:59:31PM +, Dominic Curran wrote: > Fix bug in commit 3249bb907a1dab9b0 > > Incorrectly assume that get_all_records_where() returned a list. > It infact returns a disctionary and the list iteratory needs to change > to account for this. > Thanks to Nicira for pointing

[ovs-dev] [PATCH 1/1] xenserver: Fix iteration of dictionary

2012-02-15 Thread Dominic Curran
Fix bug in commit 3249bb907a1dab9b0 Incorrectly assume that get_all_records_where() returned a list. It infact returns a disctionary and the list iteratory needs to change to account for this. Thanks to Nicira for pointing this out. NIC-454. Reported-by: David Tsai From: Rob Hoes Acked-by: Dom