Hi David,
Thanks for the submission. Since this is a bugfix for a long-running
behaviour, I reduced the patch to just the functional changes and
applied it to master, branch-2.6 and branch-2.5.
Here's the final change, please let me know if it is still missing something:
https://github.com/openvs
I'm not a C/C++ developer. Well this is very far away from my memory.
I changed the following line:
+ error = netdev_linux_get_ethtool(name, miimon);
to
+ error = netdev_linux_get_ethtool(&name, &miimon);
as it looks like we're sending adresses to functions instead of the
values.
From 2748f6325facb7d5d880d620041e2f11767abe0c Mon Sep 17 00:00:00 2001
From: David Hill
Date: Tue, 30 Aug 2016 15:13:31 -0400
Subject: [PATCH 1/1] netdev-linux.c - Trying to use miimon and on
failure failback to ethtool
Some network drivers might return true to SIOCGMIIPHY and an error on
SIO