Re: [ovs-dev] [PATCH 09/15] datapath-windows: Add macros in Debug.h

2014-08-21 Thread Samuel Ghinet
bj2, err2); I think this patch was useful if the vport patch was added. Anyway, it's not important now. Sam From: Nithin Raju [nit...@vmware.com] Sent: Saturday, August 16, 2014 9:47 AM To: Samuel Ghinet Cc: dev@openvswitch.org Subject: Re: [ovs-dev] [P

Re: [ovs-dev] [PATCH 09/15] datapath-windows: Add macros in Debug.h

2014-08-15 Thread Nithin Raju
Sam, There are lot of assumptions here about how code should be structured and written. eg. there's an implicit assumption that 'Cleanup' should be defined. Let's table this for sometime till we get the current code starts working with netlink. If you can point me to some code what is using the

[ovs-dev] [PATCH 09/15] datapath-windows: Add macros in Debug.h

2014-08-06 Thread Samuel Ghinet
Add macros in Debug.h Checks that: a) make the code shorter for functions that return BOOLEAN or OVS_ERROR, by hiding the repetitive work. b) on debug mode, do ASSERT, while on release mode can do an, e.g. "return X;" instead, for the failure case. c) by using OVS_CHECK, we can choose via OVS_US