Re: [ovs-dev] [PATCH 07/23] ovn-controller: Un-inline get_chassis_by_name().

2015-10-15 Thread Ben Pfaff
On Thu, Oct 15, 2015 at 02:04:26PM -0700, Justin Pettit wrote: > > > On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > > > I don't know of any reason to inline this. > > Well, obviously because it's on the critical path. It has to do with > registers and CPU caches and stuff--you wouldn't under

Re: [ovs-dev] [PATCH 07/23] ovn-controller: Un-inline get_chassis_by_name().

2015-10-15 Thread Justin Pettit
> On Oct 9, 2015, at 9:15 PM, Ben Pfaff wrote: > > I don't know of any reason to inline this. Well, obviously because it's on the critical path. It has to do with registers and CPU caches and stuff--you wouldn't understand. > Also rename for consistency with get_bridge(). > > Signed-off-by:

[ovs-dev] [PATCH 07/23] ovn-controller: Un-inline get_chassis_by_name().

2015-10-09 Thread Ben Pfaff
I don't know of any reason to inline this. Also rename for consistency with get_bridge(). Signed-off-by: Ben Pfaff --- ovn/controller/binding.c| 4 ++-- ovn/controller/chassis.c| 4 ++-- ovn/controller/ovn-controller.c | 14 ++ ovn/controller/ovn-controller.h | 15