Re: [ovs-dev] [PATCH 05/14] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-15 Thread Simon Horman
On Mon, Nov 12, 2012 at 09:57:26AM -0800, Ben Pfaff wrote: > On Wed, Nov 07, 2012 at 05:03:03PM +0900, Simon Horman wrote: > > This enables the use of the OpenFlow 12 flow format. > > > > Signed-off-by: Simon Horman > > Based on "grep", I'm nervous that we're missing important handling for > OFP

Re: [ovs-dev] [PATCH 05/14] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-12 Thread Ben Pfaff
On Mon, Nov 12, 2012 at 09:57:26AM -0800, Ben Pfaff wrote: > On Wed, Nov 07, 2012 at 05:03:03PM +0900, Simon Horman wrote: > > This enables the use of the OpenFlow 12 flow format. > > > > Signed-off-by: Simon Horman > > Based on "grep", I'm nervous that we're missing important handling for > OFP

Re: [ovs-dev] [PATCH 05/14] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-12 Thread Ben Pfaff
On Wed, Nov 07, 2012 at 05:03:03PM +0900, Simon Horman wrote: > This enables the use of the OpenFlow 12 flow format. > > Signed-off-by: Simon Horman Based on "grep", I'm nervous that we're missing important handling for OFPUTIL_P_OF12 in a number of places. For example, it looks like ofputil_us

[ovs-dev] [PATCH 05/14] ofp-util: Allow use of OpenFlow 12 flow format

2012-11-07 Thread Simon Horman
This enables the use of the OpenFlow 12 flow format. Signed-off-by: Simon Horman --- v4 * Rebase --- lib/ofp-util.c |2 +- lib/ofp-util.h |4 ++-- tests/learn.at |2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/lib/ofp-util.c b/lib/ofp-util.c index 562531b..930