Re: [ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

2014-11-11 Thread Simon Horman
On Mon, Nov 10, 2014 at 08:34:30PM -0800, Ben Pfaff wrote: > On Tue, Nov 11, 2014 at 10:01:03AM +0900, Simon Horman wrote: > > On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote: > > > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote: > > > > EXT-350 > > > > Signed-off-by: Simon

Re: [ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

2014-11-10 Thread Ben Pfaff
On Tue, Nov 11, 2014 at 10:01:03AM +0900, Simon Horman wrote: > On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote: > > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote: > > > EXT-350 > > > Signed-off-by: Simon Horman > > > +OFPGC15_INSERT_BUCKET = 3,/* Insert action buckets

Re: [ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

2014-11-10 Thread Simon Horman
On Tue, Nov 11, 2014 at 10:01:01AM +0900, Simon Horman wrote: > On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote: > > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote: > > > EXT-350 > > > Signed-off-by: Simon Horman > > > > Thanks, Simon! > > > > I see some misspellings of O

Re: [ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

2014-11-10 Thread Simon Horman
On Mon, Nov 10, 2014 at 09:55:53AM -0800, Ben Pfaff wrote: > On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote: > > EXT-350 > > Signed-off-by: Simon Horman > > Thanks, Simon! > > I see some misspellings of OpenFlow as "OpenFLow". Please fix those. Thanks, will do. > > > +OFPGC

Re: [ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

2014-11-10 Thread Ben Pfaff
On Mon, Nov 10, 2014 at 01:47:51PM +0900, Simon Horman wrote: > EXT-350 > Signed-off-by: Simon Horman Thanks, Simon! I see some misspellings of OpenFlow as "OpenFLow". Please fix those. > +OFPGC15_INSERT_BUCKET = 3,/* Insert action buckets to the already > available > +

[ovs-dev] [PATCH 04/22] ofproto: Add types for (draft) OpenFlow 1.5 group mod

2014-11-09 Thread Simon Horman
EXT-350 Signed-off-by: Simon Horman --- include/openflow/openflow-1.5.h | 159 +++- 1 file changed, 158 insertions(+), 1 deletion(-) diff --git a/include/openflow/openflow-1.5.h b/include/openflow/openflow-1.5.h index a5a51c0..a413755 100644 --- a/include/open