Re: [ovs-dev] [PATCH 04/21] vswitchd: Add iface_parse_tunnel

2012-05-24 Thread Simon Horman
On Thu, May 24, 2012 at 09:47:38AM -0700, Ben Pfaff wrote: > The concept seems OK to me here. I have only a few minor comments. > > On Thu, May 24, 2012 at 06:08:57PM +0900, Simon Horman wrote: > > +#define TNL_F_CSUM (1 << 0) /* Checksum packets. */ > > +#define TNL_F_TOS_INHERIT (1 <<

Re: [ovs-dev] [PATCH 04/21] vswitchd: Add iface_parse_tunnel

2012-05-24 Thread Ben Pfaff
The concept seems OK to me here. I have only a few minor comments. On Thu, May 24, 2012 at 06:08:57PM +0900, Simon Horman wrote: > +#define TNL_F_CSUM (1 << 0) /* Checksum packets. */ > +#define TNL_F_TOS_INHERIT(1 << 1) /* Inherit ToS from inner packet. */ > +#define TNL_F_TTL_INHER

[ovs-dev] [PATCH 04/21] vswitchd: Add iface_parse_tunnel

2012-05-24 Thread Simon Horman
This duplicates parse_tunnel_config, the duplication will later be minimised. iface_parse_tunnel() is currently only used to verify the configuration by passing NULL as its third argument. It will later be used in storing the configuration by passing a non-NULL argument. The purpose of verificatio