Re: [ovs-dev] [PATCH 04/13] netdev-dpdk: Use RCU for egress QoS.

2016-10-12 Thread Daniele Di Proietto
On 12/10/2016 13:04, "Ben Pfaff" wrote: >On Tue, Oct 04, 2016 at 06:22:15PM -0700, Daniele Di Proietto wrote: >> I think it's clearer to use RCU than to check for a pointer twice in the >> fast path (before and after taking the spinlock). Now the spinlock is >> integrated into 'qos_conf'. >>

Re: [ovs-dev] [PATCH 04/13] netdev-dpdk: Use RCU for egress QoS.

2016-10-12 Thread Ben Pfaff
On Tue, Oct 04, 2016 at 06:22:15PM -0700, Daniele Di Proietto wrote: > I think it's clearer to use RCU than to check for a pointer twice in the > fast path (before and after taking the spinlock). Now the spinlock is > integrated into 'qos_conf'. > > 'qos_conf' objects cannot be modified, so, inste

[ovs-dev] [PATCH 04/13] netdev-dpdk: Use RCU for egress QoS.

2016-10-04 Thread Daniele Di Proietto
I think it's clearer to use RCU than to check for a pointer twice in the fast path (before and after taking the spinlock). Now the spinlock is integrated into 'qos_conf'. 'qos_conf' objects cannot be modified, so, instead of having 'qos_set()', we now have 'qos_is_equal()', which tells us if an ob